tbaeder closed this revision.
tbaeder added a comment.
Dang, forgot to add the link to the commit message. This has been closed via
https://github.com/llvm/llvm-project/commit/6ba4b213346fad36634a5571feda4f4481097c3a
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155394/new/
https://rev
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155394/new/
https://reviews.llvm.org/D155394
___
cfe-commits mailing lis
tbaeder updated this revision to Diff 543854.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155394/new/
https://reviews.llvm.org/D155394
Files:
clang/lib/AST/Interp/Floating.h
clang/lib/AST/Interp/InterpBuiltin.cpp
clang/test/AST/Interp/builtin-functions.cpp
Index: clang/test/AST
jcranmer-intel added inline comments.
Comment at: clang/test/AST/Interp/builtin-functions.cpp:121-130
+ char classify_nan [__builtin_fpclassify(+1, -1, -1, -1, -1,
__builtin_nan(""))];
+ char classify_snan[__builtin_fpclassify(+1, -1, -1, -1, -1,
__builtin_nans(""))];
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155394/new/
https://reviews.llvm.org/D155394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
aaron.ballman added a subscriber: jcranmer-intel.
aaron.ballman added inline comments.
Comment at: clang/test/AST/Interp/builtin-functions.cpp:121-130
+ char classify_nan [__builtin_fpclassify(+1, -1, -1, -1, -1,
__builtin_nan(""))];
+ char classify_snan[__builtin_fpcl
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews