[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ad9dcb38693: [clang][Interp] Implement __builtin_isnan() (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

tbaeder updated this revision to Diff 541362. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155369/new/ https://reviews.llvm.org/D155369 Files: clang/lib/AST/Interp/Function.cpp clang/lib/AST/Interp/Function.h clang/lib/AST/Interp/Interp.cp

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

cor3ntin accepted this revision. cor3ntin added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:166-168 + // FIXME: We are not going through getParam() here, because the function + // doesn't have any paramete

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

tbaeder updated this revision to Diff 540760. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155369/new/ https://reviews.llvm.org/D155369 Files: clang/lib/AST/Interp/Function.cpp clang/lib/AST/Interp/Function.h clang/lib/AST/Interp/Interp.cp

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Function.h:180 +// FIXME: Is there a better way to get this information? +if (getName() == "__builtin_isnan") + return true; cor3ntin wrote: > t

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

tbaeder updated this revision to Diff 540692. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155369/new/ https://reviews.llvm.org/D155369 Files: clang/lib/AST/Interp/Function.cpp clang/lib/AST/Interp/Function.h clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Interp.h clang/

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/Function.h:180 +// FIXME: Is there a better way to get this information? +if (getName() == "__builtin_isnan") + return true; tbaeder wrote: > cor3ntin wrote: > > You can compare getBuil

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Function.h:180 +// FIXME: Is there a better way to get this information? +if (getName() == "__builtin_isnan") + return true; cor3ntin wrote: > You can compare getBuiltinID(), which is be

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/Function.h:180 +// FIXME: Is there a better way to get this information? +if (getName() == "__builtin_isnan") + return true; You can compare getBuiltinID(), which is better than using s

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a way to pop arguments based on the call expressio