This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf7623f4f692d: Enable zba and zbs for RISCV64 Android
(authored by AdityaK <1894981+hiradi...@users.noreply.github.com>).
Repository:
rG LLVM Githu
hiraditya added inline comments.
Comment at: clang/test/Driver/riscv-features.c:13
+// ANDROID: "-target-feature" "+zba"
// ANDROID: "-target-feature" "+zbb"
MaskRay wrote:
> If the features are adjacent, test them on one line. `// ANDROID:
> "-target-feature
asb accepted this revision.
asb added a comment.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155339/new/
https://reviews.llvm.org/D155339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
MaskRay added inline comments.
Comment at: clang/test/Driver/riscv-features.c:13
+// ANDROID: "-target-feature" "+zba"
// ANDROID: "-target-feature" "+zbb"
If the features are adjacent, test them on one line. `// ANDROID:
"-target-feature" "+zba" "-target-fea