[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4f6c229bde8: [clangd] Refine the workflow for diagnostic Fixits. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

hokein updated this revision to Diff 541546. hokein marked 2 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155173/new/ https://reviews.llvm.org/D155173 Files: clang-tools-extra/cl

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1063 + OnlyFix->isPreferred = true; + if (LSPDiags.size() == 1 && LSPDiags.front().range == Sel

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

hokein updated this revision to Diff 541481. hokein added a comment. more cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155173/new/ https://reviews.llvm.org/D155173 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

hokein updated this revision to Diff 541480. hokein marked an inline comment as done. hokein added a comment. address comments - introduce `DiagKey` for the caching map - get rid of extra index conversion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1014-1016 + llvm::ArrayRef LSPDiags = Params.context.diagnostics; + std::map + ToLSPDiagsIndex; we're already making a copy of `Params.context.diagnostics` when creati

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

hokein updated this revision to Diff 541391. hokein added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155173/new/ https://reviews.llvm.org/D155173 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clang

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

hokein updated this revision to Diff 541389. hokein marked 2 inline comments as done. hokein added a comment. add LSPServer cache back and repurpose for lsp <=> naive diagnostic mapping, per offline discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:671 + // FIMXE: this is tricky + llvm::StringRef(LSPDiag.Message) + .starts_with_insensitive(Diag.Message)) hokein wrote: > hokein wro

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:671 + // FIMXE: this is tricky + llvm::StringRef(LSPDiag.Message) + .starts_with_insensitive(Diag.Message)) hokein wrote: > kadircet wro

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

hokein updated this revision to Diff 541129. hokein added a comment. Use the mainMessage to find the corresponding ClangdServer diagnostics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155173/new/ https://reviews.llvm.org/D155173 Files: clang-

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:671 + // FIMXE: this is tricky + llvm::StringRef(LSPDiag.Message) + .starts_with_insensitive(Diag.Message)) kadircet wrote: > this is tr

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

hokein updated this revision to Diff 541009. hokein marked an inline comment as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155173/new/ https://reviews.llvm.org/D155173 Files: clang-tools-

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:671 + // FIMXE: this is tricky + llvm::StringRef(LSPDiag.Message) + .starts_with_insensitive(Diag.Message)) this is tricky indeed and

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. - Remove the diagnostic fixits m