FreddyYe added inline comments.
Comment at: clang/test/CodeGen/X86/sm4-builtins.c:5
+#include
+#include
+
RKSimon wrote:
> what is stddef.h needed for?
Good catch! probably be copy paste error.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
FreddyYe updated this revision to Diff 540950.
FreddyYe marked an inline comment as done.
FreddyYe added a comment.
Remove #include
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155148/new/
https://reviews.llvm.org/D155148
Files:
clang/docs/Rel
RKSimon added inline comments.
Comment at: clang/lib/Headers/sm4intrin.h:17
+
+#define _mm_sm4key4_epi32(A, B)
\
+ (__m128i) __builtin_ia32_vsm4key4128((__v4su)A, (__v4su)B)
doxygen descriptions?
FreddyYe updated this revision to Diff 540900.
FreddyYe marked an inline comment as done.
FreddyYe added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155148/new/
https://reviews.llvm.org/D155148
Files:
clang/docs/Re
FreddyYe marked 4 inline comments as done.
FreddyYe added inline comments.
Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8308
+RC:$src2))]>,
+ Sched<[WriteVecIMul]>;
+def rm : I<0xda, MRMSrcMem, (outs RC:$dst),
skan wrote:
> From
skan added inline comments.
Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8308
+RC:$src2))]>,
+ Sched<[WriteVecIMul]>;
+def rm : I<0xda, MRMSrcMem, (outs RC:$dst),
From the description, it seems that `WriteVecIMul` is not the rig
pengfei added inline comments.
Comment at: llvm/test/CodeGen/X86/sm4-intrinsics.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -O0 -verify-machineinstrs -mtriple=x86_64-unknown-unknown
--show-mc-encoding -mattr=+sm4 | FileChe
pengfei added inline comments.
Comment at: llvm/test/MC/Disassembler/X86/sm4-64.txt:3-4
+
+# RUN: llvm-mc --disassemble %s -triple=x86_64 | FileCheck %s
--check-prefixes=ATT
+# RUN: llvm-mc --disassemble %s -triple=x86_64 -x86-asm-syntax=intel
--output-asm-variant=1 | FileCheck
FreddyYe created this revision.
Herald added subscribers: pengfei, hiraditya.
Herald added a project: All.
FreddyYe requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
For more details about these instructions, please refer to
