[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:349 -* If the patch has been reviewed, add a link to its review page, as shown - `here

[PATCH] D155081: Specify the developer policy around links to external resources

reames added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:349 -* If the patch has been reviewed, add a link to its review page, as shown - `here `_. aaron.ballman wrote: > reames wro

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:349 -* If the patch has been reviewed, add a link to its review page, as shown - `here `_. reames wrote: > aaron.ball

[PATCH] D155081: Specify the developer policy around links to external resources

reames added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:349 -* If the patch has been reviewed, add a link to its review page, as shown - `here `_. aaron.ballman wrote: > aaron.ball

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:349 -* If the patch has been reviewed, add a link to its review page, as shown - `here

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:349 -* If the patch has been reviewed, add a link to its review page, as shown - `here `_. reames wrote: > Removing t

[PATCH] D155081: Specify the developer policy around links to external resources

reames added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:349 -* If the patch has been reviewed, add a link to its review page, as shown - `here `_. Removing this item seems very off

[PATCH] D155081: Specify the developer policy around links to external resources

This revision was automatically updated to reflect the committed changes. Closed by commit rG677326999f27: Specify the developer policy around links to external resources (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1550

[PATCH] D155081: Specify the developer policy around links to external resources

lattner accepted this revision. lattner added a comment. This revision is now accepted and ready to land. Looks like a great improvement to the policy, thank you all for sorting through this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 __

[PATCH] D155081: Specify the developer policy around links to external resources

tonic added a comment. @lattner Please review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman updated this revision to Diff 549979. aaron.ballman added a comment. Tweaked wording to link to the policy about adding links to github issues in commit messages instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 Files:

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345"; to automate closing + the issue in GitHub. If the patch has been rev

[PATCH] D155081: Specify the developer policy around links to external resources

tahonermann added a comment. This looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D155081: Specify the developer policy around links to external resources

rZhBoYao added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345"; to automate closing + the issue in GitHub. If the patch has been reviewed

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman updated this revision to Diff 549370. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 Files: llvm/docs/DeveloperPo

[PATCH] D155081: Specify the developer policy around links to external resources

cor3ntin accepted this revision. cor3ntin added a comment. This seems very reasonable to me Comment at: llvm/docs/DeveloperPolicy.rst:264 +#. Ensure that links in source code and test files are to publicly available + resources and are used primarily to add additional infor

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman updated this revision to Diff 549369. aaron.ballman added a comment. Accidentally uploaded a partial diff instead of the full set of changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 Files: llvm/docs/DeveloperPolicy.rst

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman added a comment. In D155081#4507579 , @tonic wrote: > As I mentioned on the Discourse thread, but if this policy change is made, > there should be some discussion about if this applies retroactively. Making a > note here, because it probab

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman updated this revision to Diff 549365. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updated based on review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 Files: llvm/docs/DeveloperPo

[PATCH] D155081: Specify the developer policy around links to external resources

probinson added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345"; to automate closing + the issue in GitHub. If the patch has been reviewe

[PATCH] D155081: Specify the developer policy around links to external resources

tonic added a comment. As I mentioned on the Discourse thread, but if this policy change is made, there should be some discussion about if this applies retroactively. Making a note here, because it probably should be included in the changes to Developer Policy if the radar links are not removed

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman added a comment. In D155081#4499046 , @lattner wrote: > Thank you so much for raising this issue Aaron. > > Documenting the policy in the developer policy is totally the right thing to > do given this cross-cuts individual subprojects, but

[PATCH] D155081: Specify the developer policy around links to external resources

lattner requested changes to this revision. lattner added a comment. This revision now requires changes to proceed. Thank you so much for raising this issue Aaron. Documenting the policy in the developer policy is totally the right thing to do given this cross-cuts individual subprojects, but I

[PATCH] D155081: Specify the developer policy around links to external resources

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. Approving in support, but don't consider this enough as-is. I suspect you should get @lattner approval here :) Comment at: llvm/docs/DeveloperPolicy.rst:357 -* I

[PATCH] D155081: Specify the developer policy around links to external resources

ldionne added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345"; to automate closing + the issue in GitHub. If the patch has been reviewed,

[PATCH] D155081: Specify the developer policy around links to external resources

smeenai added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345"; to automate closing + the issue in GitHub. If the patch has been reviewed,

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345"; to automate closing + the issue in GitHub. If the patch has been rev

[PATCH] D155081: Specify the developer policy around links to external resources

arsenm added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345"; to automate closing + the issue in GitHub. If the patch has been reviewed,

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman created this revision. aaron.ballman added reviewers: rnk, lattner, doug.gregor, probinson, ldionne, arsenm, mehdi_amini. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a subscriber: wdng. Herald added a project: LLVM. This specifies the d