[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

tbaeder abandoned this revision. tbaeder added a comment. Abandoning this since I've migrated it to Github: https://github.com/llvm/llvm-project/pull/68288 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154951/new/ https://reviews.llvm.org/D154951

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/InterpBitcast.cpp:71 +/// All offsets are in bytes. +struct ByteTracker { + std::vector Initialized; tbaeder wrote: > aaron.ballman wrote: > > Don't we need to track this at the *bit* level in

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/InterpBitcast.cpp:71 +/// All offsets are in bytes. +struct ByteTracker { + std::vector Initialized; aaron.ballman wrote: > Don't we need to track this at the *bit* level instead of the *byte* level

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Boolean.h:113 + static Boolean bitcastFromMemory(const std::byte *Buff) { +bool Val = static_cast(*Buff); +return Boolean(Val); tbaeder wrote: > MitalAshok wrote: > > Does this handle

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154951/new/ https://reviews.llvm.org/D154951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Boolean.h:113 + static Boolean bitcastFromMemory(const std::byte *Buff) { +bool Val = static_cast(*Buff); +return Boolean(Val); MitalAshok wrote: > Does this handle padding bits correctly? E

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

MitalAshok added inline comments. Comment at: clang/lib/AST/Interp/Boolean.h:113 + static Boolean bitcastFromMemory(const std::byte *Buff) { +bool Val = static_cast(*Buff); +return Boolean(Val); Does this handle padding bits correctly? E.g., `__builtin_b

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154951/new/ https://reviews.llvm.org/D154951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154951/new/ https://reviews.llvm.org/D154951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements `__builtin_bit_cast()`. The new opcod