[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2f7b5dbaefe: [CodeGen] Support bitcode input containing multiple modules (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

ormris accepted this revision. ormris added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154923/new/ https://reviews.llvm.org/D154923 ___

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

MaskRay updated this revision to Diff 543084. MaskRay added a comment. rename a variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154923/new/ https://reviews.llvm.org/D154923 Files: clang/lib/CodeGen/CodeGenAction.cpp clang/test/CodeGen/s

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

MaskRay updated this revision to Diff 543083. MaskRay edited the summary of this revision. MaskRay added a comment. rename a variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154923/new/ https://reviews.llvm.org/D154923 Files: clang/lib/Cod

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

ormris added a comment. This is a good way to resolve the inconsistencies I was looking at in my own review. > I think whether a bitcode input file contains 2 modules (internal > implementation strategy) should not be a criterion to require an additional > driver option Agreed. Most users don

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

MaskRay added a comment. In D154923#4491673 , @MaskRay wrote: > In D154923#4491411 , @efriedma > wrote: > >> If I follow correctly, this is basically undoing the splitting that was done >> by the command that pr

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

MaskRay added a comment. In D154923#4491411 , @efriedma wrote: > If I follow correctly, this is basically undoing the splitting that was done > by the command that produced the bitcode file? Yes, undoing `llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

efriedma added a comment. If I follow correctly, this is basically undoing the splitting that was done by the command that produced the bitcode file? I guess that could be useful. But it requires either renaming your object files from the default ".o" to ".bc", or explicitly passing "-x ir"?

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

MaskRay created this revision. MaskRay added reviewers: ormris, efriedma, rjmccall, aaron.ballman. Herald added subscribers: steven_wu, hiraditya. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When usi