[PATCH] D154893: [Clang] Fix some triviality computations

royjacobson added a comment. I, uh, got preoccupied by some recent events. Don't think I'll have the time for this unfortunately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154893/new/ https://reviews.llvm.org/D154893 _

[PATCH] D154893: [Clang] Fix some triviality computations

royjacobson added a comment. In D154893#4646405 , @cor3ntin wrote: > @royjacobson ^ I did not have a lot of time for Clang the last few months unfortunately. I might take a look at this again next month when I'll have a bit more time. Repository: rG

[PATCH] D154893: [Clang] Fix some triviality computations

cor3ntin added a comment. @royjacobson ^ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154893/new/ https://reviews.llvm.org/D154893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D154893: [Clang] Fix some triviality computations

cor3ntin added a comment. @royjacobson Are you still working on that? It seems it's only missing updates to a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154893/new/ https://reviews.llvm.org/D154893 _

[PATCH] D154893: [Clang] Fix some triviality computations

shafik added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1269 /// Determine whether this class has a non-trivial copy constructor /// (C++ [class.copy]p6, C++11 [class.copy]p12) bool hasNonTrivialCopyConstructor() const { philnik wrote

[PATCH] D154893: [Clang] Fix some triviality computations

philnik added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1269 /// Determine whether this class has a non-trivial copy constructor /// (C++ [class.copy]p6, C++11 [class.copy]p12) bool hasNonTrivialCopyConstructor() const { royjacobson

[PATCH] D154893: [Clang] Fix some triviality computations

royjacobson updated this revision to Diff 543319. royjacobson added a comment. Update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154893/new/ https://reviews.llvm.org/D154893 Files: clang/docs/ReleaseNotes.rst clang/include/clan

[PATCH] D154893: [Clang] Fix some triviality computations

royjacobson added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1269 /// Determine whether this class has a non-trivial copy constructor /// (C++ [class.copy]p6, C++11 [class.copy]p12) bool hasNonTrivialCopyConstructor() const { shafik w

[PATCH] D154893: [Clang] Fix some triviality computations

shafik added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1269 /// Determine whether this class has a non-trivial copy constructor /// (C++ [class.copy]p6, C++11 [class.copy]p12) bool hasNonTrivialCopyConstructor() const { These referen

[PATCH] D154893: [Clang] Fix some triviality computations

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. This is a bit confusing but I think it is correct. LGTM modulo typos. Comment at: clang/docs/ReleaseNotes.rst:70 --- -- A bug in evaluating the i

[PATCH] D154893: [Clang] Fix some triviality computations

royjacobson created this revision. royjacobson added a reviewer: shafik. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix #63352 and one other similar issue by slightly adjusting the computation