This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG18a628ec4ef7: [AST] Use correct APSInt width when evaluating
string literals (authored by barannikov88).
Repository:
rG LLVM Github Monorepo
CHAN
cor3ntin added a comment.
@barannikov88 Don't forget to land this!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154773/new/
https://reviews.llvm.org/D154773
___
cfe-commits mailing list
cfe-commits@list
aaron.ballman accepted this revision.
aaron.ballman added a comment.
I think this is a good NFC change as it brings us one TINY step closer towards
supporting platforms where `CHAR_BIT != 8`. But I agree with Corentin that a
lot more work needs to happen to support that kind of target; restartin
cor3ntin accepted this revision.
cor3ntin added a subscriber: aaron.ballman.
cor3ntin added a comment.
This revision is now accepted and ready to land.
I think this is fine, and it's a nice simplification.
However it doesn't seem to do much of anything in practice: if you look at
`StringLiteral:
barannikov88 created this revision.
barannikov88 added a reviewer: cor3ntin.
Herald added a project: All.
barannikov88 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The width of the APSInt values should be the width of an element.
getChar
