[PATCH] D154688: [clang] Show verify prefix in error messages

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4e0589b2cd9: [clang][Verify] Show prefix in -verify error messages (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https:/

[PATCH] D154688: [clang] Show verify prefix in error messages

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 ___ cfe-commits mailing lis

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder added inline comments. Comment at: clang/test/Frontend/verify.c:159 + +// what-error {{huh?}} +// CHECK9: error: 'what-error' diagnostics expected but not seen: MaskRay wrote: > This may need a comment explaining that this is not recognized as a directive

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder updated this revision to Diff 543298. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 Files: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp clang/test/ARCMT/verify.m clang/test/Frontend/ve

[PATCH] D154688: [clang] Show verify prefix in error messages

MaskRay added inline comments. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:881 + std::string KindStr = Prefix + "-" + Kind; + Diags.Report(diag::err_verify_inconsistent_diags).setForceEmit() The variables are immediately used. I think in this

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder updated this revision to Diff 543260. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 Files: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp clang/test/ARCMT/verify.m clang/test/Frontend/verify-any-file.c clang/test/Frontend/veri

[PATCH] D154688: [clang] Show verify prefix in error messages

aaron.ballman added a comment. Precommit CI found relevant failures that should be addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder updated this revision to Diff 542768. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 Files: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp clang/test/Frontend/verify-any-file.c clang/test/Frontend/verify-fatal.c clang/test/Fron

[PATCH] D154688: [clang] Show verify prefix in error messages

MaskRay added a comment. The change looks great: (from `error: 'error' diagnostics seen but not expected:` to `error: 'expected-error' diagnostics seen but not expected`). When I read Clang tests, I was confused by what `error` meant. I eventually figured out `-verify` is special. The new diagno

[PATCH] D154688: [clang] Show verify prefix in error messages

aaron.ballman added a comment. In D154688#4499797 , @tbaeder wrote: > In D154688#4498398 , @aaron.ballman > wrote: > >> In D154688#4497967 , @tbaeder >> wrote: >> >>> Wh

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder added a comment. In D154688#4498398 , @aaron.ballman wrote: > In D154688#4497967 , @tbaeder wrote: > >> When passing a different prefix via `-verify=foo`, the error messages now >> say "error: 'foo-error

[PATCH] D154688: [clang] Show verify prefix in error messages

aaron.ballman added a comment. In D154688#4497967 , @tbaeder wrote: > When passing a different prefix via `-verify=foo`, the error messages now say > "error: 'foo-error' diagnostics seen but not expected", etc. > > I'm often working in test files where t

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder added a comment. When passing a different prefix via `-verify=foo`, the error messages now say "error: 'foo-error' diagnostics seen but not expected", etc. I'm often working in test files where two different prefixes are used and I'm always confused about which one of the two the error

[PATCH] D154688: [clang] Show verify prefix in error messages

aaron.ballman added a comment. I'm not opposed but I am wondering what the need is for this? (It'd be good to capture that information in the patch summary as well.) Some examples showing where this helps to correct the issue would be useful. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder updated this revision to Diff 538058. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 Files: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp clang/test/Frontend/verify-any-file.c clang/test/Frontend/verify-fatal.c clang/test/Fron

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder created this revision. tbaeder added a reviewer: clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154688 Files: clang/lib