Re: [PATCH] D15463: [Objective-c] Fix a crash

2015-12-15 Thread Akira Hatanaka via cfe-commits
Thank you for the review. I added a test to check the "redeclaration of type parameter" error message and committed it as r255754. On Tue, Dec 15, 2015 at 4:55 PM, Justin Bogner wrote: > Akira Hatanaka writes: > > On Tue, Dec 15, 2015 at 12:55 PM, Justin Bogner > > wrote: > > > >> Akira Hatana

Re: [PATCH] D15463: [Objective-c] Fix a crash

2015-12-15 Thread Akira Hatanaka via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255754: [Objective-c] Fix a crash that occurs when ObjCTypeParamList::back() is (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D15463?vs=42560&id=42962#toc Repository: rL LL

Re: [PATCH] D15463: [Objective-c] Fix a crash

2015-12-15 Thread Justin Bogner via cfe-commits
Akira Hatanaka writes: > On Tue, Dec 15, 2015 at 12:55 PM, Justin Bogner > wrote: > >> Akira Hatanaka writes: >> > On Mon, Dec 14, 2015 at 10:39 AM, Justin Bogner >> > wrote: >> > >> >> Akira Hatanaka via cfe-commits writes: >> >> > ahatanak created this revision. >> >> > ahatanak added a subs

Re: [PATCH] D15463: [Objective-c] Fix a crash

2015-12-15 Thread Akira Hatanaka via cfe-commits
On Tue, Dec 15, 2015 at 12:55 PM, Justin Bogner wrote: > Akira Hatanaka writes: > > On Mon, Dec 14, 2015 at 10:39 AM, Justin Bogner > > wrote: > > > >> Akira Hatanaka via cfe-commits writes: > >> > ahatanak created this revision. > >> > ahatanak added a subscriber: cfe-commits. > >> > > >> > T

Re: [PATCH] D15463: [Objective-c] Fix a crash

2015-12-15 Thread Justin Bogner via cfe-commits
Akira Hatanaka writes: > On Mon, Dec 14, 2015 at 10:39 AM, Justin Bogner > wrote: > >> Akira Hatanaka via cfe-commits writes: >> > ahatanak created this revision. >> > ahatanak added a subscriber: cfe-commits. >> > >> > This patch fixes a crash that occurs when __kindof is incorrectly used >> >

Re: [PATCH] D15463: [Objective-c] Fix a crash

2015-12-14 Thread Akira Hatanaka via cfe-commits
On Mon, Dec 14, 2015 at 10:39 AM, Justin Bogner wrote: > Akira Hatanaka via cfe-commits writes: > > ahatanak created this revision. > > ahatanak added a subscriber: cfe-commits. > > > > This patch fixes a crash that occurs when __kindof is incorrectly used > > in the type parameter list of an in

Re: [PATCH] D15463: [Objective-c] Fix a crash

2015-12-14 Thread Justin Bogner via cfe-commits
Akira Hatanaka via cfe-commits writes: > ahatanak created this revision. > ahatanak added a subscriber: cfe-commits. > > This patch fixes a crash that occurs when __kindof is incorrectly used > in the type parameter list of an interface. The crash occurs because > ObjCTypeParamList::back() is call

[PATCH] D15463: [Objective-c] Fix a crash

2015-12-11 Thread Akira Hatanaka via cfe-commits
ahatanak created this revision. ahatanak added a subscriber: cfe-commits. This patch fixes a crash that occurs when __kindof is incorrectly used in the type parameter list of an interface. The crash occurs because ObjCTypeParamList::back() is called in checkTypeParamListConsistency on an empty