[PATCH] D154596: [RISCV] Fix required features checking with empty string

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8fe0449ac990: [RISCV] Fix required features checking with empty string (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D154596: [RISCV] Fix required features checking with empty string

wangpc accepted this revision. wangpc added a comment. LGTM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154596/new/ https://reviews.llvm.org/D154596 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D154596: [RISCV] Fix required features checking with empty string

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154596/new/ https://reviews.llvm.org/D154596 ___

[PATCH] D154596: [RISCV] Fix required features checking with empty string

Jim added a comment. In D154596#4499757 , @wangpc wrote: > In D154596#4499718 , @Jim wrote: > >> In D154596#4499647 , @wangpc wrote: >> >>> Can you give an example of intr

[PATCH] D154596: [RISCV] Fix required features checking with empty string

wangpc added a comment. In D154596#4499718 , @Jim wrote: > In D154596#4499647 , @wangpc wrote: > >> Can you give an example of intrinsic that doesn't require any extra >> extension enabled? > > Like read/write cs

[PATCH] D154596: [RISCV] Fix required features checking with empty string

Jim added a comment. In D154596#4499647 , @wangpc wrote: > Can you give an example of intrinsic that doesn't require any extra extension > enabled? Like read/write csr intrinsics that we add for convenient usage doesn't need any extra extension enabled

[PATCH] D154596: [RISCV] Fix required features checking with empty string

craig.topper added a comment. This seems reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154596/new/ https://reviews.llvm.org/D154596 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D154596: [RISCV] Fix required features checking with empty string

wangpc added a comment. Can you give an example of intrinsic that doesn't require any extra extension enabled? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154596/new/ https://reviews.llvm.org/D154596

[PATCH] D154596: [RISCV] Fix required features checking with empty string

Jim added a comment. Kindly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154596/new/ https://reviews.llvm.org/D154596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D154596: [RISCV] Fix required features checking with empty string

Jim created this revision. Herald added subscribers: jobnoorman, VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, arichardson. Herald added a project: All. Jim requested review of this revision. Herald added subscribers: cfe