[PATCH] D154543: [llvm] Move StringExtras.h include from Error.h to Error.cpp

MaskRay added a comment. > [llvm] Move StringExtras.h include from Error.h to Error.cpp If you land the #include changes separately, I think the tag can be changed to `[Support] `. `Support` is sufficient to refer to llvm-project/llvm/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1545

[PATCH] D154543: [llvm] Move StringExtras.h include from Error.h to Error.cpp

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. I have spot checked a few files and the additional #include looks great! As mentioned in the other patch, it would be better landing the #include adjustment part separately so that the `llvm/

[PATCH] D154543: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 538047. IncludeGuardian added a comment. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Fix `XCOFFDump.cpp` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154543/new/ https://reviews.llvm.org/D154543 Files: clang/li

[PATCH] D154543: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 537886. IncludeGuardian added a comment. Fix `CompressionTest.cpp` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154543/new/ https://reviews.llvm.org/D154543 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/BareMetal.cp

[PATCH] D154543: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian created this revision. Herald added subscribers: ormris, hiraditya. Herald added a project: All. IncludeGuardian requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Add missing parts that caused https: