Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

aaron.ballman closed this revision. aaron.ballman added a comment. Commit in r257521 http://reviews.llvm.org/D15443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

adek05 added a comment. Would you mind committing it for me, and I don't have a commit access yet. Also, could you take a look at http://reviews.llvm.org/D15444 with tests for clang-tidy related to this change? http://reviews.llvm.org/D15443 ___ cf

Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D15443#324426, @adek05 wrote: > Adding testcases in unittest/AST/SourceLocationTest.cpp as suggested by > @aaronballman > > Interestingly, without my c

Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

adek05 updated this revision to Diff 44598. adek05 added a comment. Adding testcases in unittest/AST/SourceLocationTest.cpp as suggested by @aaronballman Interestingly, without my change tests for function declarations pass. Only member functions fail: tools/clang/unittests/AST/ASTTests ..

Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

aaron.ballman added a comment. In http://reviews.llvm.org/D15443#323043, @adek05 wrote: > I think this won't work. If there is a problem with the expression inside > `throw` or `noexcept` specifier, it will be highlighted inside the parens, > never trying to actually access the end location of

Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

adek05 added a comment. I think this won't work. If there is a problem with the expression inside `throw` or `noexcept` specifier, it will be highlighted inside the parens, never trying to actually access the end location of the function declaration. It would be enough if there is a warning/err

Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

aaron.ballman added a comment. Sorry for the delay in reviewing this! In terms of a test case, presumably you need this because a diagnostic location is incorrect -- would it be possible to write the exception specification such that it is on its own line, and then expect-warning|error|note on

Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

adek05 added reviewers: aaron.ballman, jroelofs. adek05 added a comment. Ping http://reviews.llvm.org/D15443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits