[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

ldionne added a comment. LGTM, but as a matter of process, please try to wait for someone from the libc++ review group before submitting. Thanks for the fix! Comment at: libcxx/include/__tree:379-380 _LIBCPP_ASSERT_UNCATEGORIZED(__z != nullptr, "The node to remove should

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG1e35e93e30c2: [libc++] Disable tree invariant check in asserts mode (authored by hans). Repository: rG LLVM Github Mono

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

hans added a comment. In D154417#4471141 , @alexfh wrote: > Given the comment in https://reviews.llvm.org/D153672#4468348, I think, this > should be fine to submit. Sounds good to me. Happy to follow up if libc++ maintainers have more input. Repositor

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

alexfh added a comment. Given the comment in https://reviews.llvm.org/D153672#4468348, I think, this should be fine to submit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154417/new/ https://reviews.llvm.org/D154417

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

alexfh accepted this revision. alexfh added a comment. Thanks for the temporary fix, Hans! We're also affected by this. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154417/new/ https://reviews.llvm.org/D154417 __

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

hans created this revision. hans added reviewers: var-const, ldionne. Herald added a project: All. hans requested review of this revision. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. This is a follow-up to D153672