[PATCH] D154328: [AST] Add API to iterate already loaded specializations

2023-07-31 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D154328#4542457 , @Hahnfeld wrote: > Let me see if I can come up a fix for that in `clang-repl` that would then > need this API. But for now, it's also fine for us if the patch stays pending > in review, still better th

[PATCH] D154328: [AST] Add API to iterate already loaded specializations

2023-07-28 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. Right, it's not ideal to land APIs without usage in Clang itself... The context is, once again, ROOT and the Cling interpreter (where we are already using this API via downstream patches): When unloading a "transaction" (now `PartialTranslationUnit` in `clang-repl`) we

[PATCH] D154328: [AST] Add API to iterate already loaded specializations

2023-07-25 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. > which might be problematic in some contexts. I'd appreciate some more details on what those contexts are. It's a bit unpleasant to expose these APIs as part of the public interface because we typically *do* want deserialization. I'm not opposed to the changes, b

[PATCH] D154328: [AST] Add API to iterate already loaded specializations

2023-07-20 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154328/new/ https://reviews.llvm.org/D154328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D154328: [AST] Add API to iterate already loaded specializations

2023-07-03 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld created this revision. Hahnfeld added reviewers: erichkeane, aaron.ballman. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These new functions allow to look at specializations without triggeri