[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

2023-07-11 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. In D154295#4482818 , @HaohaiWen wrote: > In D154295#4477203 , @hans wrote: > >> In D154295#4477165 , @HaohaiWen >> wrote: >> It would be nice t

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

2023-07-08 Thread Haohai, Wen via Phabricator via cfe-commits
HaohaiWen added a comment. In D154295#4477203 , @hans wrote: > In D154295#4477165 , @HaohaiWen > wrote: > >>> It would be nice to have some documentation for this feature though. >> >> This feature is same as Lin

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

2023-07-06 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. In D154295#4477165 , @HaohaiWen wrote: >> It would be nice to have some documentation for this feature though. > > This feature is same as Linux -gsplit-dwarf. Right, but it would be nice to document that clang-cl supports it (which

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

2023-07-06 Thread Haohai, Wen via Phabricator via cfe-commits
HaohaiWen added a comment. Thanks everyone. > It would be nice to have some documentation for this feature though. This feature is same as Linux -gsplit-dwarf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154295/new/ https://reviews.llvm.org/D15

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

2023-07-06 Thread Haohai, Wen via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf97b61ed27aa: [Driver][MSVC] Support DWARF fission when using LTO on Windows (authored by HaohaiWen). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

2023-07-06 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. Looks reasonable to me too. It would be nice to have some documentation for this feature though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154295/new/ https://reviews.llvm.org/D154295 ___

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

2023-07-05 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo accepted this revision. mstorsjo added subscribers: hans, rnk. mstorsjo added a comment. This revision is now accepted and ready to land. I think this looks reasonable, unless e.g. @hans or @rnk would disagree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

2023-07-01 Thread Haohai, Wen via Phabricator via cfe-commits
HaohaiWen created this revision. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. HaohaiWen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. D154070 ha