[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

JOE1994 updated this revision to Diff 536552. JOE1994 added a comment. - Undo some refactorings to make the diff more consistent with commit message (following feedback from @jrtc27) - Remove method CreateElementBitCast (following feedback from @nikic) Repository: rG LLVM Github Monorepo CH

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

jrtc27 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:158 /// This method is to be deprecated. Use `Address::withElementType` instead. + [[deprecated("Use `Address::withElementType` instead.")]] jrtc27 wrote: > JOE1994 wrote: > > nikic wro

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

jrtc27 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:158 /// This method is to be deprecated. Use `Address::withElementType` instead. + [[deprecated("Use `Address::withElementType` instead.")]] JOE1994 wrote: > nikic wrote: > > JOE1994 wr

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:158 /// This method is to be deprecated. Use `Address::withElementType` instead. + [[deprecated("Use `Address::withElementType` instead.")]] nikic wrote: > JOE1994 wrote: > > > This i

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

jrtc27 added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3896 llvm::Type *OrigBaseElemTy = Addr.getElementType(); -Addr = Builder.CreateElementBitCast(Addr, Int8Ty); JOE1994 wrote: > barannikov88 wrote: > > jrtc27 wrote: > > > This one is

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3896 llvm::Type *OrigBaseElemTy = Addr.getElementType(); -Addr = Builder.CreateElementBitCast(Addr, Int8Ty); barannikov88 wrote: > jrtc27 wrote: > > This one isn't a direct substit

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3954 Function *F = CGM.getIntrinsic(Intrinsic::eh_sjlj_setjmp); -Buf = Builder.CreateElementBitCast(Buf, Int8Ty); return RValue::get(Builder.CreateCall(F, Buf.getPointer()));

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

barannikov88 accepted this revision. barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3954 Function *F = CGM.getIntrinsic(Intrinsic::eh_sjlj_setjmp); -Buf = Builder.CreateElementBitCast(Buf, Int8Ty); return RValue::get(Builder.CreateCa

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGBuilder.h:158 /// This method is to be deprecated. Use `Address::withElementType` instead. + [[deprecated("Use `Address::withElementT

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

jrtc27 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3954 Function *F = CGM.getIntrinsic(Intrinsic::eh_sjlj_setjmp); -Buf = Builder.CreateElementBitCast(Buf, Int8Ty); return RValue::get(Builder.CreateCall(F, Buf.getPointer()));

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:158 /// This method is to be deprecated. Use `Address::withElementType` instead. + [[deprecated("Use `Address::withElementType` instead.")]] Repository: rG LLVM Github Monorepo C

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

JOE1994 created this revision. JOE1994 added reviewers: barannikov88, nikic. Herald added subscribers: luke, StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, si