This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa57bdc8fe687: [clang] Fix leak in
LoadFromCommandLineWorkingDirectory unit test (authored by hamishknight,
committed by bnbarham).
Changed prior to
hamishknight marked an inline comment as done.
hamishknight added inline comments.
Comment at: clang/tools/libclang/CIndex.cpp:3965
unsaved_files);
- std::unique_ptr Unit(ASTUnit::LoadFromCommandLine(
+ auto Unit = ASTUnit::LoadFromCommandLine(
Args->data(), Args-
hamishknight updated this revision to Diff 536426.
hamishknight added a comment.
Updated to use explicit `std::unique_ptr`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154257/new/
https://reviews.llvm.org/D154257
Files:
clang/include/clang/Frontend/ASTUnit.h
clang/lib/CrossTU/Cros
benlangmuir accepted this revision.
benlangmuir added a comment.
Gotta love `return AST.release()` being passed directly back into
`std::unique_ptr(...)`. Thanks for fixing!
Comment at: clang/tools/libclang/CIndex.cpp:3965
unsaved_files);
- std::unique_ptr Unit(ASTUni
hamishknight created this revision.
hamishknight added a reviewer: bnbarham.
hamishknight added a project: clang.
Herald added subscribers: arphaman, martong.
Herald added a project: All.
hamishknight requested review of this revision.
Herald added a subscriber: cfe-commits.
Change `ASTUnit::LoadF
