[PATCH] D154253: [clang] detect integer overflow through temporary values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb776e2a0b03e: [clang] detect integer overflow through temporary values (authored by lnihlen). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D154253: [clang] detect integer overflow through temporary values

lnihlen updated this revision to Diff 536466. lnihlen added a comment. remove extrneous clang:: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154253/new/ https://reviews.llvm.org/D154253 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaCh

[PATCH] D154253: [clang] detect integer overflow through temporary values

aeubanks added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15215 Exprs.append(Construct->arg_begin(), Construct->arg_end()); +else if (auto Temporary = dyn_cast(E)) + Exprs.push_back(Temporary->getSubExpr()); nit: `clang::` isn't

[PATCH] D154253: [clang] detect integer overflow through temporary values

lnihlen added a comment. Added release note, fixed commit log. PTAL, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154253/new/ https://reviews.llvm.org/D154253 ___ cfe-commits mailing list cfe-co

[PATCH] D154253: [clang] detect integer overflow through temporary values

lnihlen updated this revision to Diff 536413. lnihlen added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154253/new/ https://reviews.llvm.org/D154253 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.

[PATCH] D154253: [clang] detect integer overflow through temporary values

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154253/new/ https://reviews.llvm.org/D154253 ___

[PATCH] D154253: [clang] detect integer overflow through temporary values

shafik added a comment. Nice catch, I missed that in my last fix: https://reviews.llvm.org/D137897 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154253/new/ https://reviews.llvm.org/D154253 ___ cfe-commi

[PATCH] D154253: [clang] detect integer overflow through temporary values

cjdb added a comment. > Fixes GH63629. Would you mind changing this to `Fixes #63629` please? That'll get it connected in GitHub. The patch looks good, would you mind adding some release notes before I give LGTM please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D154253: [clang] detect integer overflow through temporary values

lnihlen created this revision. Herald added a project: All. lnihlen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes GH63629. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154253 Files: clang/lib/Sema/SemaChecki