This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2ca74162258b: [clang][DeclPrinter] Fix AST print of
delegating constructors (authored by strimo378).
Repository:
rG LLVM Github Monorepo
CHANGES
strimo378 added a comment.
I plan around half a dozen patches only for ast-print functionality. I would
love to land it myself and will asked for commit privileges.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154186/new/
https://reviews.llvm.org
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! Do you need me to commit this on your behalf? (If you plan to do more
patches, I'm also happy to let you ask for commit privileges
[https://llvm.org/docs/DeveloperPolicy.ht
strimo378 marked 3 inline comments as done.
strimo378 added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154186/new/
https://reviews.llvm.org/D154186
___
cfe-commits mailing list
cfe-com
strimo378 updated this revision to Diff 540627.
strimo378 added a comment.
Updated test case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154186/new/
https://reviews.llvm.org/D154186
Files:
clang/lib/AST/DeclPrinter.cpp
clang/test/AST/ast-pri
aaron.ballman added inline comments.
Comment at: clang/test/AST/ast-print-method-decl.cpp:15
+ // CHECK-NEXT: };
+};
strimo378 wrote:
> aaron.ballman wrote:
> > I'd also like to see test cases along the lines of:
> > ```
> > struct B {
> > template
> > B(Ty
strimo378 added inline comments.
Comment at: clang/test/AST/ast-print-method-decl.cpp:15
+ // CHECK-NEXT: };
+};
aaron.ballman wrote:
> I'd also like to see test cases along the lines of:
> ```
> struct B {
> template
> B(Ty);
> B(int X) : B((float)X) {}
aaron.ballman added a comment.
Thank you for the fix! This generally LGTM, but I did find some extra test
cases to add.
Comment at: clang/test/AST/ast-print-method-decl.cpp:1
+// RUN: %clang_cc1 -ast-print %s -o - | FileCheck %s
+
I think the file should be na
strimo378 created this revision.
strimo378 added a reviewer: aaron.ballman.
strimo378 added a project: clang.
Herald added a project: All.
strimo378 requested review of this revision.
Herald added a subscriber: cfe-commits.
DeclPrinter::PrintConstructorInitializers did not consider delegating
ini
