FreddyYe added a comment.
Thanks review!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154181/new/
https://reviews.llvm.org/D154181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa9256a2e0450: [x86] Add missing FeatureCMOV in frontend
targets. (authored by FreddyYe).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154181/new/
https://reviews.llvm.org/D154181
___
craig.topper added inline comments.
Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:325
+ { {"pentiumpro"}, CK_PentiumPro, ~0U, FeatureCMOV | FeatureX87 |
FeatureCMPXCHG8B },
+ { {"i686"}, CK_i686, ~0U, FeatureCMOV | FeatureX87 | FeatureCMPXCHG8B },
{ {"pentium2"}, CK
craig.topper added inline comments.
Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:325
+ { {"pentiumpro"}, CK_PentiumPro, ~0U, FeatureCMOV | FeatureX87 |
FeatureCMPXCHG8B },
+ { {"i686"}, CK_i686, ~0U, FeatureCMOV | FeatureX87 | FeatureCMPXCHG8B },
{ {"pentium2"}, CK
FreddyYe created this revision.
Herald added subscribers: pengfei, hiraditya.
Herald added a project: All.
FreddyYe requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
The missing info is gathered from X86.td.
Repository:
