[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG289828b1c0a6: [Driver][MSVC] Move lld specific flags before inputs (authored by HaohaiWen, committed by hh ). Repository: rG LLVM

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. In D154176#4466230 , @HaohaiWen wrote: > In D154176#4466190 , @mstorsjo > wrote: > >> In D154176#4466186

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

HaohaiWen added a comment. In D154176#4466190 , @mstorsjo wrote: > In D154176#4466186 , @mstorsjo > wrote: > >> Ok, thanks for clarifying. However I still don’t understand the “why” aspect >> here. You’re writin

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

mstorsjo added a comment. In D154176#4466186 , @mstorsjo wrote: > Ok, thanks for clarifying. However I still don’t understand the “why” aspect > here. You’re writing > >> so that lld specific flags can be append before inputs > > Are you planning on addi

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

mstorsjo added a comment. Ok, thanks for clarifying. However I still don’t understand the “why” aspect here. You’re writing > so that lld specific flags can be append before inputs Are you planning on adding such flags in a later patch, position dependent flags that need to be supplied before

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

HaohaiWen updated this revision to Diff 536518. HaohaiWen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154176/new/ https://reviews.llvm.org/D154176 Files: clang/lib/Driver/ToolChains/MSVC.cpp clang/test/Driver/msvc-lin

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

HaohaiWen added a comment. In D154176#4465223 , @mstorsjo wrote: > Is this a NFC change, as a preparation for a separate change? In that case, > please add an NFC tag to the subject - if not, please explain (and test) the > expected behaviour change. T

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

HaohaiWen updated this revision to Diff 536502. HaohaiWen added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154176/new/ https://reviews.llvm.org/D154176 Files: clang/lib/Driver/ToolChains/MSVC.cpp clang/test/Driver/msvc-

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

mstorsjo added a comment. Is this a NFC change, as a preparation for a separate change? In that case, please add an NFC tag to the subject - if not, please explain (and test) the expected behaviour change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

HaohaiWen created this revision. Herald added a project: All. HaohaiWen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Check linker earlier so that lld specific flags can be append before inputs. Just like position of other flags.