[PATCH] D154091: [clang-format] Prefer breaking long strings at new lines

2023-06-30 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. is there a git issue for this, I'm struggling to understand the problem we are solving. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154091/new/ https://reviews.llvm.org/D154091 ___

[PATCH] D154091: [clang-format] Prefer breaking long strings at new lines

2023-06-29 Thread sstwcw via Phabricator via cfe-commits
sstwcw added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:225 +return BreakableToken::Split(NewLine, 0); + if (AfterSpace >= 2) +return BreakableToken::Split(AfterSpace, 0); Should I change the threshold from 2 to 1? It is set to 2 b

[PATCH] D154091: [clang-format] Prefer breaking long strings at new lines

2023-06-29 Thread sstwcw via Phabricator via cfe-commits
sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Previously, escape sequences in string literals were not rec