Re: [PATCH] D15395: Add 3 more missing inline/visibility attributes

2015-12-09 Thread Evgeniy Stepanov via cfe-commits
eugenis closed this revision. eugenis added a comment. r255166 Repository: rL LLVM http://reviews.llvm.org/D15395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15395: Add 3 more missing inline/visibility attributes

2015-12-09 Thread Evgeniy Stepanov via cfe-commits
eugenis added a comment. Should be fine. Repository: rL LLVM http://reviews.llvm.org/D15395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15395: Add 3 more missing inline/visibility attributes

2015-12-09 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. For clang this patch should have no functionality change because clang allows attributes to appear only in the declaration. GCC however was previously ignoring the attributes and only n

[PATCH] D15395: Add 3 more missing inline/visibility attributes

2015-12-09 Thread Evgeniy Stepanov via cfe-commits
eugenis created this revision. eugenis added reviewers: EricWF, mclow.lists. eugenis added a subscriber: cfe-commits. eugenis set the repository for this revision to rL LLVM. These are the cases when an out-of-class definition of a method is marked _LIBCPP_INLINE_VISIBILITY, but the in-class decl