[PATCH] D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX

2023-10-30 Thread Digger Lin via Phabricator via cfe-commits
DiggerLin added inline comments. Comment at: clang/include/clang/Driver/Options.td:3405 +def mtocdata : Flag<["-"], "mtocdata">, + Visibility<[ClangOption, CLOption, DXCOption, CC1Option]>, + Flags<[TargetSpecific]>, do we need `CLOption, DXCOption` here ? thes

[PATCH] D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX

2023-09-28 Thread Zaara Syeda via Phabricator via cfe-commits
syzaara added inline comments. Comment at: clang/include/clang/Driver/Options.td:2955 + MarshallingInfoFlag>; +def mno_tocdata_EQ : CommaJoined<["-"], "mno-tocdata=">, + Flags<[CC1Option,TargetSpecific]>, MaskRay wrote: > If `-mtocdata=` is opt-in, the conventi

[PATCH] D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX

2023-08-29 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/docs/UsersManual.rst:3161 +static storage duration, including static data members of classes and +block-scope static variables will be marked with the toc-data attribute. +Alternatively, the user can specify a comma

[PATCH] D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX

2023-08-29 Thread Zaara Syeda via Phabricator via cfe-commits
syzaara updated this revision to Diff 554461. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153907/new/ https://reviews.llvm.org/D153907 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/c