[PATCH] D153849: [clang][Diagnostics] Fix diagnostic line numbers

2023-06-30 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8554a55d041f: [clang][Diagnostics] Fix diagnostic line numbers (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D153849: [clang][Diagnostics] Fix diagnostic line numbers

2023-06-30 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. In D153849#4463001 , @tbaeder wrote: > @cor3ntin Thanks. You're very close to getting on my default reviewer list > though, so be careful ;) Thanks for the heads up, I might add you to mine :D Repository: rG LLVM Github Mon

[PATCH] D153849: [clang][Diagnostics] Fix diagnostic line numbers

2023-06-30 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. @cor3ntin Thanks. You're very close to getting on my default reviewer list though, so be careful ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153849/new/ https://reviews.llvm.org/D153849 __

[PATCH] D153849: [clang][Diagnostics] Fix diagnostic line numbers

2023-06-30 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. That works as well as far as I know, but I changed it locally to just use the issue ID anyway. Could you set the status to accepted? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153849/new/ https://reviews.llvm.or

[PATCH] D153849: [clang][Diagnostics] Fix diagnostic line numbers

2023-06-29 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb added a comment. LGTM. Not sure if the `Fixes https://github.com/llvm/llvm-project/issues/63524` line autocloses the issue, but note that `Fixes #63524` does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153849/new/ https://reviews.llvm.org/

[PATCH] D153849: [clang][Diagnostics] Fix diagnostic line numbers

2023-06-27 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: cjdb, aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The first line of the code snippet we print is potentially lower than the