[PATCH] D153738: Add LibClang guide

aaron.ballman added a comment. In D153738#4484865 , @manuel5975p wrote: > I guess manuel5975p (manuel.wink...@gmx.ch) would be nice Thank you for the new documentation, it's really appreciated! I've landed this on your behalf in 12d72e4fdee91b3f1e31475

[PATCH] D153738: Add LibClang guide

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12d72e4fdee9: Add libClang guide (authored by manuel5975p, committed by aaron.ballman). Herald added a subscriber: arphaman. Changed prior to commit

[PATCH] D153738: Add LibClang guide

manuel5975p added a comment. I guess manuel5975p (manuel.wink...@gmx.ch) would be nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153738/new/ https://reviews.llvm.org/D153738 ___ cfe-commits mailing l

[PATCH] D153738: Add LibClang guide

aaron.ballman added a comment. LGTM, thank you! Do you need me to commit this on your behalf? If so, what name and email address would you like me to use for patch attribution? (I'll build the docs locally and correct any remaining formatting mistakes before landing.) Repository: rG LLVM Git

[PATCH] D153738: Add LibClang guide

manuel5975p updated this revision to Diff 538333. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153738/new/ https://reviews.llvm.org/D153738 Files: clang/docs/LibClang.rst Index: clang/docs/LibClang.rst ===

[PATCH] D153738: Add LibClang guide

aaron.ballman added a comment. In D153738#4474602 , @manuel5975p wrote: > Incorporate Aaron Ballman's corrections Hmm, something seems to have gone sideways somewhere because it looks like none of the comments were addressed -- did you perhaps re-uploa

[PATCH] D153738: Add LibClang guide

manuel5975p updated this revision to Diff 537443. manuel5975p marked 9 inline comments as done. manuel5975p added a comment. Incorporate Aaron Ballman's corrections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153738/new/ https://reviews.llvm.org/

[PATCH] D153738: Add LibClang guide

manuel5975p accepted this revision. manuel5975p added a comment. This revision is now accepted and ready to land. Thanks a lot for carefully going through this. I will dispose of the documentation for CXType after accepting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D153738: Add LibClang guide

aaron.ballman added a comment. Thank you for adding this new documentation! In general, this is looking fantastic. Given how closely tied the C indexing APIs are with the rest of the compiler internals, I think it'd be helpful to add links to https://clang.llvm.org/docs/InternalsManual.html to

[PATCH] D153738: Add LibClang guide

manuel5975p created this revision. manuel5975p added a reviewer: aaron.ballman. manuel5975p added projects: clang, clang-c. Herald added a project: All. manuel5975p requested review of this revision. Herald added a subscriber: cfe-commits. Add a libclang .rst file with some code examples, going ov