This revision was automatically updated to reflect the committed changes.
Closed by commit rG2ae8a4a17888: [ASTMatchers] Add argumentCountAtLeast
narrowing matcher (authored by mikecrowe, committed by PiotrZSL).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.ll
PiotrZSL updated this revision to Diff 534363.
PiotrZSL added a comment.
Rebase + Added change to Registry.cpp
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153716/new/
https://reviews.llvm.org/D153716
Files:
clang/docs/LibASTMatchersReference.h
PiotrZSL added a comment.
NOTE: Registry.cpp were not changed, I will add it there during commit if all
tests locally pass. If tests fail, I will just add this matcher as private in
clang-tidy check.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1
PiotrZSL accepted this revision.
PiotrZSL added a comment.
This revision is now accepted and ready to land.
LGTM, Personally probably I would extract this to this level, and I would leave
it private to a check, but it's fine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ht
mikecrowe created this revision.
mikecrowe added a reviewer: PiotrZSL.
Herald added a project: All.
mikecrowe requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
mikecrowe added inline comments.
Comment at: clang/unittests/AST
mikecrowe added inline comments.
Comment at: clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:1671
+ notMatches("void x(int, int = 1) { x(0); }",
+ traverse(TK_IgnoreUnlessSpelledInSource, Call2PlusArgs)));
+ EXPECT_TRUE(
I'm not sur
