[PATCH] D153702: [Clang] Implement P2738R1 - constexpr cast from void*

2023-06-29 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/test/CXX/expr/expr.const/p5-26.cpp:13 +(void)static_cast(a); //cxx23-note {{cast from 'void *' is not allowed in a constant expression in C++ standards before C++2c}} +(void)static_cast(a); +(void)static_cast(a);

[PATCH] D153702: [Clang] Implement P2738R1 - constexpr cast from void*

2023-06-26 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/test/CXX/expr/expr.const/p5-26.cpp:13 +(void)static_cast(a); //cxx23-note {{cast from 'void *' is not allowed in a constant expression in C++ standards before C++2c}} +(void)static_cast(a); +(void)static_cast(a); --

[PATCH] D153702: [Clang] Implement P2738R1 - constexpr cast from void*

2023-06-26 Thread Corentin Jabot via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf27afedc6c86: [Clang] Implement P2738R1 - constexpr cast from void* (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D153702: [Clang] Implement P2738R1 - constexpr cast from void*

2023-06-26 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8920 + if (HasValidResult) +CCEDiag(E, diag::note_constexpr_invalid_void_star_cast) +<< SubExpr->getType() << Info.getLangOpts().CPlusPlus26 erichkeane

[PATCH] D153702: [Clang] Implement P2738R1 - constexpr cast from void*

2023-06-26 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 534524. cor3ntin added a comment. Add tests for C++23 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153702/new/ https://reviews.llvm.org/D153702 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basi

[PATCH] D153702: [Clang] Implement P2738R1 - constexpr cast from void*

2023-06-26 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8920 + if (HasValidResult) +CCEDiag(E, diag::note_constexpr_invalid_void_star_cast) +<< SubExpr->getType() << Info.getLangOpts().CPlusPlus26 Does thi

[PATCH] D153702: [Clang] Implement P2738R1 - constexpr cast from void*

2023-06-25 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 534328. cor3ntin added a comment. Rebase and update feature macro tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153702/new/ https://reviews.llvm.org/D153702 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D153702: [Clang] Implement P2738R1 - constexpr cast from void*

2023-06-24 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D153702 Files: clang/docs/ReleaseNotes.rst clang/incl