[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder abandoned this revision. tbaeder added a comment. This was pushed as part of the initializer rework. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153653/new/ https://reviews.llvm.org/D153653 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153653/new/ https://reviews.llvm.org/D153653 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153653/new/ https://reviews.llvm.org/D153653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153653/new/ https://reviews.llvm.org/D153653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153653/new/ https://reviews.llvm.org/D153653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1022 + +if (DiscardResult) + return this->emitPopPtr(E); shafik wrote: > Could you just pass `DiscardResult` to `visitLocalInitializer` Nope, the `visitInitializer` funct

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1022 + +if (DiscardResult) + return this->emitPopPtr(E); Could you just pass `DiscardResult` to `visitLocalInitializer` CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder updated this revision to Diff 534174. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153653/new/ https://reviews.llvm.org/D153653 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/records.cpp Index: clang/test/AST/Interp/records.cpp ==

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. visitLocalInitializer() pops the pointer from the