[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir closed this revision. schittir added a comment. In D153589#4493187 , @HazardyKnusperkeks wrote: > Can you mark this change as closed? > If you'd put "Differential Revision: https://reviews.llvm.org/D153589"; in > your commit message this would

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

HazardyKnusperkeks added a comment. Can you mark this change as closed? If you'd put "Differential Revision: https://reviews.llvm.org/D153589"; in your commit message this would have happened automatically. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added a comment. Thank you all for reviewing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.org/D153589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

owenpan accepted this revision. owenpan added a comment. The clang-format part LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.org/D153589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

tahonermann accepted this revision. tahonermann added a comment. These changes look fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.org/D153589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir updated this revision to Diff 535050. schittir added a comment. Remove stale comment about default constructor not initializing members in a useful way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.org/D153589 Files: clang/lib/Analysis/CFG.

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren(S);

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren(S);

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren(S);

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

erichkeane added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren(S)

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:58 /// used as arguments will necessarily be available at construction time. - LazyRuntimeFunction() - : CGM(nullptr), FunctionName(nullptr), Function(nullptr) {} + LazyRuntimeFunction() {} --

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren(S);

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir updated this revision to Diff 533798. schittir added a comment. Make the constructor default. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.org/D153589 Files: clang/lib/Analysis/CFG.cpp clang/lib/CodeGen/CGObjCGNU.cpp clang/lib/Format/Unw

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

erichkeane added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren(S)

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir updated this revision to Diff 533794. schittir added a comment. Address comment- Use default member initialization instead of initializing in a constructor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.org/D153589 Files: clang/lib/Analysis/

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir marked an inline comment as done. schittir added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentially

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

erichkeane added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren(S)

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir created this revision. schittir added reviewers: aaron.ballman, erichkeane, tahonermann. Herald added subscribers: cfe-commits, steakhal, martong. Herald added a reviewer: NoQ. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyD