[PATCH] D153576: [Headers] Fix up some conditionals

pengfei added a comment. In D153576#4442096 , @craig.topper wrote: > The mulx function being 32-bit mode only is also true in gcc. It probably > won't generate a mulx instruction on x86-64. Maybe that's why it was 32-bit > only? But it should still be

[PATCH] D153576: [Headers] Fix up some conditionals

probinson closed this revision. probinson added a comment. Committed [[here|https://github.com/llvm/llvm-project/commit/3db8410487ce704f02ef8a175e87295d4e86c8df]] and closing manually because I forgot to put the review link in the commit message. CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D153576: [Headers] Fix up some conditionals

probinson added a comment. The Intel documentation doesn't hint that `_mulx_32` isn't available in 64-bit mode. I'm guessing gcc messed up and we copied them. CHANGES SINCE

[PATCH] D153576: [Headers] Fix up some conditionals

craig.topper added a comment. The mulx function being 32-bit mode only is also true in gcc. It probably won't generate a mulx instruction on x86-64. Maybe that's why it was 32-bit only? But it should still be functionally correct. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153576/ne

[PATCH] D153576: [Headers] Fix up some conditionals

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153576/new/ https://reviews.llvm.org/D153576 ___ cfe-commits mailing list c

[PATCH] D153576: [Headers] Fix up some conditionals

probinson created this revision. probinson added reviewers: craig.topper, RKSimon, pengfei, goldstein.w.n. Herald added a project: All. probinson requested review of this revision. While looking at adding intrinsic function descriptions, I found some oddities in the conditionals. I've fiddled with