[PATCH] D153417: New CharSetConverter wrapper class for ConverterEBCDIC

2023-06-27 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan added a comment. > I don't think anyone is particularly against the concept of adding a charset > conversion API; most of the discussion is around the choice to implement the > API as a thin wrapper around POSIX iconv(). And that concern applies equally > no matter wher

[PATCH] D153417: New CharSetConverter wrapper class for ConverterEBCDIC

2023-06-26 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. In D153417#4449812 , @abhina.sreeskantharajan wrote: > In D153417#4438764 , @efriedma > wrote: > >> As I mentioned at >> https://discourse.llvm.org/t/rfc-enabling-fexec-charset-support

[PATCH] D153417: New CharSetConverter wrapper class for ConverterEBCDIC

2023-06-26 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan added a comment. In D153417#4438764 , @efriedma wrote: > As I mentioned at > https://discourse.llvm.org/t/rfc-enabling-fexec-charset-support-to-llvm-and-clang-reposting/71512 > , I think SimplifyLibCalls needs to be aware of enco

[PATCH] D153417: New CharSetConverter wrapper class for ConverterEBCDIC

2023-06-21 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. As I mentioned at https://discourse.llvm.org/t/rfc-enabling-fexec-charset-support-to-llvm-and-clang-reposting/71512 , I think SimplifyLibCalls needs to be aware of encodings. To make that work, this probably needs to be somewhere in llvm/ , not clang/ . Repository:

[PATCH] D153417: New CharSetConverter wrapper class for ConverterEBCDIC

2023-06-21 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan created this revision. Herald added a project: All. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is adding a wrapper class called CharSetConverter for ConverterEBCDIC which was