[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55e199a2c9f4: [clang][WebAssembly] Support wasm32-wasi shared libraries (authored by dicej, committed by sbc100). Changed prior to commit: https:/

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. @sbc100 @sunfish I believe I've addressed all your feedback so far. Anything else you'd like me to do before we call this ready? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 __

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej updated this revision to Diff 533375. dicej added a comment. remove config.py changes per review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

sbc100 added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:347 +return triple + m = re.match(r"(\w+)-(\w+)-(\w+)", triple) dicej wrote: > sbc100 wrote: > > Are the the changes to this file meant to be part of this CL? > The `

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. In D153293#4437877 , @sbc100 wrote: > In D153293#4437644 , @dicej wrote: > >> In D153293#4436629 , @sbc100 wrote: >> >>> I'm happy to merge it, but

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

sbc100 added a comment. In D153293#4437644 , @dicej wrote: > In D153293#4436629 , @sbc100 wrote: > >> I'm happy to merge it, but perhaps we should get @sunfish to lg too. >> >> Also, should we remove the `-experim

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej updated this revision to Diff 533243. dicej added a comment. update release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/ToolChains/W

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. In D153293#4436629 , @sbc100 wrote: > I'm happy to merge it, but perhaps we should get @sunfish to lg too. > > Also, should we remove the `-experimental-pic` linker flag, or are you OK > with that warning from the linker? If yes,

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. In D153293#4437583 , @sunfish wrote: > This patch appears to be just the release notes and the test; is the actual > driver change missing? Sorry -- this is the first time I've used `arc`, and I apparently messed up. I meant to

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

sunfish added a comment. This patch appears to be just the release notes and the test; is the actual driver change missing? Comment at: clang/docs/ReleaseNotes.rst:706 + limited to the Emscripten target OS and now works with other targets such as + wasm32-wasi. ---

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

sbc100 added a comment. I'm happy to merge it, but perhaps we should get @sunfish to lg too. Also, should we remove the `-experimental-pic` linker flag, or are you OK with that warning from the linker? If yes, I wonder if we should do that as part of this CL or a followup? Repository: rG

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. @sbc100 Thanks for the "lgtm". What's the next step to get this merged? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 ___ cfe-commits

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 __

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej updated this revision to Diff 532705. dicej added a comment. generalize Wasm tests and release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 Files: clang/docs/ReleaseNotes.rst clang/test

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. Thanks for the review. I'll post an update shortly. Comment at: clang/docs/ReleaseNotes.rst:705 +- The `wasm32-wasi` target now supports `Emscripten-style shared libraries + `

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

sbc100 added a comment. Herald added a subscriber: ormris. Nice! lgtm with a couple of nits Comment at: clang/docs/ReleaseNotes.rst:705 +- The `wasm32-wasi` target now supports `Emscripten-style shared libraries +

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej created this revision. Herald added subscribers: pmatos, asb, delcypher, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: All. dicej requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay, aheejin. Herald added projects: