[PATCH] D153259: [clangd] Store offsets in MacroOccurrence

2023-06-23 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7298bcf7f061: [clangd] Store offsets in MacroOccurrence (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D153259: [clangd] Store offsets in MacroOccurrence

2023-06-23 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 533873. hokein marked 2 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153259/new/ https://reviews.llvm.org/D153259 Files: clang-tools-extra/cl

[PATCH] D153259: [clangd] Store offsets in MacroOccurrence

2023-06-22 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/CollectMacros.cpp:37 Out.Names.insert(Name); - auto Range = halfOpenToRange( - SM, CharSourceRange::getCharRan

[PATCH] D153259: [clangd] Store offsets in MacroOccurrence

2023-06-19 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Remove the existing `Rng` field.