[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

This revision was automatically updated to reflect the committed changes. Closed by commit rG899c86779440: [clang-format] Fixed bad performance with enabled qualifier fixer. (authored by Sedeniono, committed by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono marked an inline comment as done. Sedeniono added a comment. In D153228#4446523 , @MyDeveloperDay wrote: > For us to land this for you we'll need your name and email Please use: `Sedenion <39583823+sedeni...@users.noreply.github.com>` Thanks!

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

MyDeveloperDay added a comment. For us to land this for you we'll need your name and email Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153228/new/ https://reviews.llvm.org/D153228 ___ cfe-commits maili

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono marked 6 inline comments as done. Sedeniono added inline comments. Comment at: clang/lib/Format/Format.cpp:3476-3477 + + // Regarding the 16: Note that multiple passes are added in + // addQualifierAlignmentFixerPasses(). + SmallVector Passes; Hazard

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono updated this revision to Diff 534024. Sedeniono added a comment. As suggested by the reviewers, the noop fixes are now filtered only if the qualifier alignment passes are active. Also implemented the other minor refactorings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:3571-3585 + // Don't make replacements that replace nothing. This can affect e.g. the + // output of clang-format with the --output-replacements-xml option. + tooling::Replacements NonNoOpFixes; + for (con

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3476-3477 + + // Regarding the 16: Note that multiple passes are added in + // addQualifierAlignmentFixerPasses(). + SmallVector Passes; owenpan wrote: > This comment is unnecess

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono marked an inline comment as done. Sedeniono added inline comments. Comment at: clang/lib/Format/Format.cpp:3571-3585 + // Don't make replacements that replace nothing. This can affect e.g. the + // output of clang-format with the --output-replacements-xml option. + t

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Thank you for the detailed analysis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153228/new/ https://reviews.llvm.org/D153228 ___ c

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:3476-3477 + + // Regarding the 16: Note that multiple passes are added in + // addQualifierAlignmentFixerPasses(). + SmallVector Passes; This comment is unnecessary and too verbose IMO. I s

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Please wait for at least @MyDeveloperDay to say something, as he is the original author of the work. Comment at: clang/lib/Format/Format.cpp:3475

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono marked 2 inline comments as done. Sedeniono added inline comments. Comment at: clang/lib/Format/Format.cpp:3475 AnalyzerPass; SmallVector Passes; HazardyKnusperkeks wrote: > Just increase here, and add a comment that there are multiple passe

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono updated this revision to Diff 532721. Sedeniono added a comment. As suggested by HazardyKnusperkeks, increased the number of stack elements and removed the reserve(). That causes all Passes to be stored on the stack. (I counted 17 distinct possible passes, but not all of them can be ac

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

HazardyKnusperkeks added a comment. I'm shocked, astonished and in awe how small this patch is. Great work and explanation! Comment at: clang/lib/Format/Format.cpp:3475 AnalyzerPass; SmallVector Passes; Just increase here, and add a comment that th

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono created this revision. Sedeniono added a reviewer: MyDeveloperDay. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan. Sedeniono requested review of this revision. This fixes github issue #5