[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

Patryk27 abandoned this revision. Patryk27 added a comment. Superseded by: - https://reviews.llvm.org/D154785 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153197/new/ https://reviews.llvm.org/D153197 _

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

benshi001 added a comment. In D153197#4483230 , @Patryk27 wrote: > ping ping, @benshi001 👀 Could you please upload your final version of this patch ? I see you have made some changes, but only mentioned in your comment. Repository: rG LLVM Github Mo

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

Patryk27 added a comment. ping ping, @benshi001 👀 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153197/new/ https://reviews.llvm.org/D153197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

Patryk27 added a comment. Now that I think about it, there //might// be a simpler way! So, the underlying issue is that sometimes LLVM spawns new shifts during the instruction selection pass - for instance given this IR¹: define i64 @test(i64 %x, i32 %y) { start: %0 = or i32 %y, 38

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:2207 + MF->push_back(LoopBB); + MachineBasicBlock *ExitBB = EntryBB->splitAt(MI, false); + Patryk27 wrote: > Alright, this is wrong, after all - I've just tested it on a more e

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

Patryk27 added inline comments. Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:2207 + MF->push_back(LoopBB); + MachineBasicBlock *ExitBB = EntryBB->splitAt(MI, false); + Alright, this is wrong, after all - I've just tested it on a more elaborate code in r

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

Patryk27 added inline comments. Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:2193 +// (the output registers are stored in this array on return). +static MachineBasicBlock *insertMultibyteShiftLoop( +MachineInstr &MI, MachineBasicBlock *BB, Register ShiftNum, --

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

Patryk27 created this revision. Herald added subscribers: Jim, JDevlieghere, hiraditya, dylanmckay. Herald added a project: All. Patryk27 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Some passes can introduce shifts aft