[PATCH] D153109: [clang-format][NFC] Clean up unit tests

2023-06-16 Thread Owen Pan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG20b4df1ed611: [clang-format][NFC] Clean up unit tests (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153109/new/ https://reviews.llvm.

[PATCH] D153109: [clang-format][NFC] Clean up unit tests

2023-06-16 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. Because FormatTestCSharp.cpp, FormatTestJS.cpp, and FormatTestSelective.cpp don't `#include` FormatTestBase.h, they can't benefit from `verifyNoChange`. However, the rest of the unit tests are all free of the repeated arguments in `EXPECT_EQ` and `verifyFormat` (as far

[PATCH] D153109: [clang-format][NFC] Clean up unit tests

2023-06-16 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Nice! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153109/new/ https://reviews.llvm.org/D153109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D153109: [clang-format][NFC] Clean up unit tests

2023-06-16 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 532192. owenpan added a comment. Cleaned up FormatTestJS.cpp as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153109/new/ https://reviews.llvm.org/D153109 Files: clang/unittests/Format/FormatTest.cpp clang/unittests/Format/FormatTestBase.

[PATCH] D153109: [clang-format][NFC] Clean up unit tests

2023-06-16 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. This patch adds a `verifyNoChange` macro to verify code that won't