t-rasmud added inline comments.
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2264
+ // variable `x` implicates fixing `y`:
DepMapTy PtrAssignmentGraph{};
+
ziqingluo-90 wrote:
> ziqingluo-90 wrote:
> > How about changing the variable name to `PtrImpli
ziqingluo-90 added inline comments.
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2264
+ // variable `x` implicates fixing `y`:
DepMapTy PtrAssignmentGraph{};
+
ziqingluo-90 wrote:
> How about changing the variable name to `PtrImplicationGraph`? For t
ziqingluo-90 added inline comments.
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2085
continue;
}
for (const auto &F : Fixables) {
I changed the rest of this function drastically so let me explain what I did.
The table `FixItsForVariable
ziqingluo-90 created this revision.
ziqingluo-90 added reviewers: NoQ, t-rasmud, jkorous, malavikasamak.
Herald added a project: All.
ziqingluo-90 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
For a function `F` whose parameters need to b