[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06eee734c1ea: [clang] Allow 'nomerge' attribute for function pointers (authored by eddyz87). Changed prior to commit: https://reviews.llvm.org/D15

[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

eddyz87 updated this revision to Diff 534585. eddyz87 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152986/new/ https://reviews.llvm.org/D152986 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDoc

[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

eddyz87 updated this revision to Diff 533824. eddyz87 added a comment. Rebase, `nomerge` documentation updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152986/new/ https://reviews.llvm.org/D152986 Files: clang/include/clang/Basic/Attr.td

[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. In D152986#4426256 , @eddyz87 wrote: > In D152986#4425736 , @rnk wrote: > >> The purpose of the attribute is really

[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

eddyz87 added a comment. In D152986#4425736 , @rnk wrote: > Thank you for the review! > The purpose of the attribute is really limited to preserving source location > information on instructions, and this isn't really a supported usage. But it would

[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

rnk added a comment. The purpose of the attribute is really limited to preserving source location information on instructions, and this isn't really a supported usage. The BPF backend and verifier needs to learn to tolerate valid LLVM transforms if it wants to be a real LLVM backend. Of course,

[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

eddyz87 added subscribers: dfaust, jemarch. eddyz87 added a comment. Hi @jemarch, @dfaust, You might be interested in this discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152986/new/ https://reviews.llvm.org/D152986

[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

eddyz87 added reviewers: rnk, yonghong-song. eddyz87 added a subscriber: rnk. eddyz87 added a comment. Hi @aaron.ballman, @rnk, I see that you were involved in the discussion when `nomerge` attribute was added in D79121 . Could you please take a look at this prop

[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

eddyz87 created this revision. Herald added a reviewer: aaron.ballman. Herald added subscribers: jeroen.dobbelaere, jdoerfert. Herald added a project: All. eddyz87 published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow specifying 'nomerge'