[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41447f6fdfe4: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 updated this revision to Diff 539544. qiongsiwu1 added a comment. Address test case review comments. Thanks so much @MaskRay for the feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D152924 Fi

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

MaskRay accepted this revision. MaskRay added a comment. Some nits about testing, otherwise LG In D152924#4490950 , @qiongsiwu1 wrote: > In D152924#4490581 , @MaskRay wrote: > >> We have `TargetOptions::DisableI

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added a comment. In D152924#4490581 , @MaskRay wrote: > We have `TargetOptions::DisableIntegratedAS` (your llc.cpp change). Do you > know why it is not feasible for the places you want to check? I am checking/using `TargetOptions::DisableInte

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

MaskRay added a comment. We have `TargetOptions::DisableIntegratedAS` (your llc.cpp change). Do you know why it is not feasible for the places you want to check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D1

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

MaskRay added inline comments. Comment at: clang/test/Driver/lto-aix.c:76 // CSPGO: "-bplugin_opt:-cs-profile-generate" "-bplugin_opt:-cs-profile-path=default_%m.profraw" +// +// Test integrated assembler options This `^//$` line is not useful. Some tests use t

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added a comment. @MaskRay @w2yehia @shchenz could you let me know if there are further comments? I will land this patch if there are none. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D15292

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 updated this revision to Diff 532256. qiongsiwu1 added a comment. Clean up code in `addLTOOptions`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D152924 Files: clang/lib/Driver/ToolChains/CommonAr

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 marked an inline comment as done. qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:703 +Arg *A = Args.getLastArgNoClaim(options::OPT_fno_integrated_as); +D.Diag(diag::warn_drv_unsupported_lto_option_for_target) +<

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 updated this revision to Diff 532241. qiongsiwu1 edited the summary of this revision. qiongsiwu1 added a comment. Address code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D152924 Files: c

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:703 +Arg *A = Args.getLastArgNoClaim(options::OPT_fno_integrated_as); +D.Diag(diag::warn_drv_unsupported_lto_option_for_target) +<< A->getSpelling() << ToolChain.getTriple().getT

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:703 +Arg *A = Args.getLastArgNoClaim(options::OPT_fno_integrated_as); +D.Diag(diag::warn_drv_unsupported_lto_option_for_target) +<< A->getSpelling() << ToolChain.getTriple().g

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 marked an inline comment as done. qiongsiwu1 added a comment. In D152924#4426895 , @shchenz wrote: > Seems passing `-Wl,-bplugin_opt:-no-integrated-as=1` from clang driver does > not work as expected. Is this expected or by design(We can only

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 marked 3 inline comments as done. qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegrat

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 updated this revision to Diff 532110. qiongsiwu1 added a comment. Revising the option processing logic to not pass in `-no-integrated-as=0`. Thanks @shchenz and @MaskRay for the feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:703 +Arg *A = Args.getLastArgNoClaim(options::OPT_fno_integrated_as); +D.Diag(diag::warn_drv_unsupported_lto_option_for_target) +<< A->getSpelling() << ToolChain.getTriple().getT

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { shchenz wrote: > qiongs

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

shchenz added a comment. Seems passing `-Wl,-bplugin_opt:-no-integrated-as=1` from clang driver does not work as expected. Is this expected or by design(We can only use -fno-integrated-as but no -Wl,-bplugin_opt:-no-integrated-as=1)? clang -flto -Wl,-bplugin_opt:-no-integrated-as=1 *.c -v

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { qiongsiwu1 wrote: > shc

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { shchenz wrote: > qio

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { qiongsiwu1 wrote: > shc

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { shchenz wrote: > See

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

shchenz added a comment. @qiongsiwu1 Hi, thanks for the patch. Almost good to me, except one small nit. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. I see. Sounds fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D152924

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added a comment. In D152924#4421624 , @steven_wu wrote: > `lld` does not use LTOCodeGenerator. > > I am also not sure how disable integrated assembler suppose to work? Do you > have an end to end design for how to invoke assembler during linki

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as`

steven_wu added a comment. `lld` does not use LTOCodeGenerator. I am also not sure how disable integrated assembler suppose to work? Do you have an end to end design for how to invoke assembler during linking? For current libLTO API, this is probably going to produce assembler file buffer to l

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as`

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay, shchenz, Esme. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: l