This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa79995ca6004: [Driver] Allow warning for unclaimed
TargetSpecific options (authored by MaskRay).
Repository:
rG LLVM Github Monorepo
CHANGES SINC
MaskRay updated this revision to Diff 532167.
MaskRay added a comment.
avoid `mutable`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152856/new/
https://reviews.llvm.org/D152856
Files:
clang/include/clang/Driver/Options.td
clang/lib/Driver/Dri
mstorsjo added inline comments.
Comment at: llvm/include/llvm/Option/Arg.h:53
+ /// This is used for generating an "argument unused" warning (without
+ /// clang::driver::options::TargetSpecific) or "unsupported option" error
+ /// (with TargetSpecific).
MaskR
MaskRay added inline comments.
Comment at: llvm/include/llvm/Option/Arg.h:53
+ /// This is used for generating an "argument unused" warning (without
+ /// clang::driver::options::TargetSpecific) or "unsupported option" error
+ /// (with TargetSpecific).
mstors
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
Looks great to me, thanks! (Didn't test it myself yet though.) Just one small
nit.
Comment at: llvm/include/llvm/Option/Arg.h:53
+ /// This is used for generating an "a
MaskRay created this revision.
MaskRay added reviewers: jansvoboda11, mstorsjo, xen0n, SixWeining.
Herald added a subscriber: hiraditya.
Herald added a project: All.
MaskRay requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
