[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG762cb1d37736: [clang][dataflow] Create `Value`s for integer literals. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

mboehme marked 2 inline comments as done. mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Arena.h:89 + /// `Value`. These literals are the same every time. + IntegerValue &makeIntLiteral(llvm::APInt Value); + xazax.hun wrot

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

mboehme updated this revision to Diff 531863. mboehme added a comment. Clarify that integer literals aren't typed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152813/new/ https://reviews.llvm.org/D152813 Files: clang/include/clang/Analysis/Flo

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Arena.h:89 + /// `Value`. These literals are the same every time. + IntegerValue &makeIntLiteral(llvm::APInt Value); + gribozavr2 wrote: > Should we be taking the type into

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Arena.h:89 + /// `Value`. These literals are the same every time. + IntegerValue &makeIntLiteral(llvm::APInt Value); + Should we be takin

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

mboehme added a comment. PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152813/new/ https://reviews.llvm.org/D152813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

mboehme updated this revision to Diff 531694. mboehme added a comment. Always return the same `Value` for the same integer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152813/new/ https://reviews.llvm.org/D152813 Files: clang/include/clang/Ana

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

mboehme added a comment. In D152813#4420471 , @gribozavr2 wrote: > In D152813#4420448 , @mboehme wrote: > >> We would expect analysis of this code to converge too -- right? > > Yes - but we might need universal t

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

gribozavr2 added a comment. In D152813#4420448 , @mboehme wrote: > We would expect analysis of this code to converge too -- right? Yes - but we might need universal top values for that? maybe? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

mboehme added a comment. In D152813#4420445 , @gribozavr2 wrote: > In D152813#4420399 , @mboehme wrote: > >> It looks to me as if the values we're now newly producing for integer >> literals are causing non-conv

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

gribozavr2 added a comment. In D152813#4420399 , @mboehme wrote: > It looks to me as if the values we're now newly producing for integer > literals are causing non-convergence of the analysis on the for-loop. For integer literals specifically, we should

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

mboehme added a comment. Pre-merge check failures are in a test for the unchecked-optional-access check clang-tidy. The test that's failing is the following from unchecked-optional-access.cpp: c++ void multiple_unchecked_accesses(absl::optional opt1, absl:

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch includes a test that fails without th