[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

aaron.ballman added a comment. In D152752#4641396 , @rnk wrote: > Following up, the vararg fix is here: > https://github.com/llvm/llvm-project/pull/65692 Thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

rnk added a comment. Following up, the vararg fix is here: https://github.com/llvm/llvm-project/pull/65692 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152752/new/ https://reviews.llvm.org/D152752 ___

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

mstorsjo added a comment. In D152752#4626234 , @rnk wrote: > I need to get to it, my recollection is that @mstorsjo ran into the same > issue here for mingw and made some changes, I wanted to go dig those up as a > starting point. I may have completely

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

rnk added a comment. I put together a fix here: https://github.com/llvm/llvm-project/compare/main...rnk:llvm-project:fix-vararg-align I don't have arcanist set up like I used to, and I don't write as much code as I used to, so I kind of want to submit this as a pull request as soon as they are

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

rnk added a subscriber: mstorsjo. rnk added a comment. I need to get to it, my recollection is that @mstorsjo ran into the same issue here for mingw and made some changes, I wanted to go dig those up as a starting point. I may have completely forgotten things though. Repository: rG LLVM Gith

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

aaron.ballman added a comment. In D152752#4611206 , @aaron.ballman wrote: > In D152752#4611043 , @rnk wrote: > >> Thanks, I think this is a clang bug. As I understand MSVC's behavior, we >> should not pass highl

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

aaron.ballman added a comment. In D152752#4611043 , @rnk wrote: > Thanks, I think this is a clang bug. As I understand MSVC's behavior, we > should not pass highly aligned variadic arguments indirectly: > https://gcc.godbolt.org/z/Kr67xWTeE > > I'll fol

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

rnk added a comment. Thanks, I think this is a clang bug. As I understand MSVC's behavior, we should not pass highly aligned variadic arguments indirectly: https://gcc.godbolt.org/z/Kr67xWTeE I'll follow up on that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

aaron.ballman added a comment. Intel is seeing some fallout from this change in our downstream (reverting this commit causes our test case to pass). Our test looks like this: #include #include #include #include typedef union { char c[32]; short s[16]; int

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG651e5ae62d29: [MS] Fix passing aligned records by value in some cases (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152752/new/ https://reviews.llvm.org/D152752 ___ c

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

rnk created this revision. rnk added reviewers: nikic, hans. Herald added subscribers: StephenFan, pengfei. Herald added a project: All. rnk requested review of this revision. Herald added a project: clang. It's not exactly clear what the meaning of TypeInfo::AlignRequirement is, so go directly to