[PATCH] D152741: [WPD] implement -funknown-vtable-visibility-filepaths

modimo added a comment. In D152741#4445807 , @wenlei wrote: >> For concrete data are you talking about between the different solutions e.g. >> --lto-whole-program-visibility, -funknown-vtable-visibility-filepaths, RTTI >> based, FatLTO based etc or some

[PATCH] D152741: [WPD] implement -funknown-vtable-visibility-filepaths

wenlei added a comment. > For concrete data are you talking about between the different solutions e.g. > --lto-whole-program-visibility, -funknown-vtable-visibility-filepaths, RTTI > based, FatLTO based etc or something else? Right, between the different solutions. RTTI based solution doesn't e

[PATCH] D152741: [WPD] implement -funknown-vtable-visibility-filepaths

modimo updated this revision to Diff 534134. modimo added a comment. Feedback, add documentation for flag and unknown visibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152741/new/ https://reviews.llvm.org/D152741 Files: clang/docs/LTOVis

[PATCH] D152741: [WPD] implement -funknown-vtable-visibility-filepaths

modimo marked 4 inline comments as done. modimo added a comment. In D152741#4445112 , @wenlei wrote: >> The big advantage of doing this in the FE is that we know which types are >> actually coming from the native headers. Blocking all types in the TU is

[PATCH] D152741: [WPD] implement -funknown-vtable-visibility-filepaths

wenlei added a comment. > The big advantage of doing this in the FE is that we know which types are > actually coming from the native headers. Blocking all types in the TU is > overly conservative and also less stable as header changes can effectively > turn on/off unrelated large chunks of WPD

[PATCH] D152741: [WPD] implement -funknown-vtable-visibility-filepaths

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152741/new/ https://reviews.llvm.org/D152741 _