[PATCH] D152696: Prevent deadlocks in death tests.

mgorny added a comment. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152696/new/ https://reviews.llvm.org/D152696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D152696: Prevent deadlocks in death tests.

mboehme added a comment. In D152696#4430238 , @mgorny wrote: > This change is causing a lot of unittests to fail on Gentoo. I've tested both > on amd64 and arm64; on amd64 additionally the test suite seems to hang. > ... Sorry, only just saw this now. I

[PATCH] D152696: Prevent deadlocks in death tests.

mgorny added a comment. This change is causing a lot of unittests to fail on Gentoo. I've tested both on amd64 and arm64; on amd64 additionally the test suite seems to hang. Failed Tests (75): LLVM-Unit :: ADT/./ADTTests/APFloatTest/SemanticsDeath LLVM-Unit :: ADT/./ADTTests/APIntTest/

[PATCH] D152696: Prevent deadlocks in death tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdfbcee286b9b: Prevent deadlocks in death tests. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152696/new/ https://reviews.llvm.org/D1

[PATCH] D152696: Prevent deadlocks in death tests.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152696/new/ https://reviews.llvm.org/D152696 ___ cfe

[PATCH] D152696: Prevent deadlocks in death tests.

mboehme updated this revision to Diff 530789. mboehme added a comment. Set the `death_test_style` flag globally in TestMain.cpp instead of each individual test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152696/new/ https://reviews.llvm.org/D152

[PATCH] D152696: Prevent deadlocks in death tests.

mboehme added a comment. In D152696#4413626 , @hans wrote: > I'm no expert here, but I went to check what Chromium does, and it seems to > set the death_test_style to "threadsafe" for the whole test suite: > https://source.chromium.org/chromium/chromium

[PATCH] D152696: Prevent deadlocks in death tests.

hans added a comment. I'm no expert here, but I went to check what Chromium does, and it seems to set the death_test_style to "threadsafe" for the whole test suite: https://source.chromium.org/chromium/chromium/src/+/main:base/test/test_suite.cc;l=367 > As the page linked above notes, "flags ar

[PATCH] D152696: Prevent deadlocks in death tests.

mboehme created this revision. Herald added a subscriber: thopre. Herald added a project: All. mboehme requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. We have recently started seeing deadlocks in death tests while running