[PATCH] D152689: [NFC] Remove dead conditionals

schittir added a comment. Patch landed with commit id 0e444c57c85853c86e4f4c94d9a51fb459fd9922 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152689/new/ https://reviews.llvm.org/D152689 _

[PATCH] D152689: [NFC] Remove dead conditionals

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152689/new/ https://reviews.llvm.org/D152689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D152689: [NFC] Remove dead conditionals

schittir added a comment. Thank you for the review, @aaron.ballman and @rjmccall The latest patch fixes clang-format issue causing build failure. Could you please take a look at this again? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152689/new/ https://reviews.llvm.org/D152

[PATCH] D152689: [NFC] Remove dead conditionals

schittir updated this revision to Diff 530702. schittir added a comment. Fix clang-format issue in SemaOverload.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152689/new/ https://reviews.llvm.org/D152689 Files: clang/lib/CodeGen/CGObjCMac.cpp clang/lib/Sema/SemaOverload.cpp ll

[PATCH] D152689: [NFC] Remove dead conditionals

aaron.ballman accepted this revision. aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:3812 llvm::GlobalVariable *GV; - if (ForClass) -GV = rjmccall wrote: > aaron.ballman wrote: > > I agree this is dead code (see line 3777

[PATCH] D152689: [NFC] Remove dead conditionals

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:3812 llvm::GlobalVariable *GV; - if (ForClass) -GV = aaron.ballman wrote: > I agree this is dead

[PATCH] D152689: [NFC] Remove dead conditionals

aaron.ballman added a subscriber: rjmccall. aaron.ballman added a comment. The other two changes LGTM, but the objc changes bring up a question about what the correct fix is. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:3812 llvm::GlobalVariable *GV; - if (ForClass) -GV

[PATCH] D152689: [NFC] Remove dead conditionals

schittir created this revision. schittir added reviewers: tahonermann, aaron.ballman, erichkeane. Herald added a subscriber: hiraditya. Herald added a project: All. schittir requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.