[PATCH] D152686: [clangd] Enforce strict unused includes by default

2023-06-27 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. In D152686#4449481 , @cjdb wrote: > This patch seems to have broken clangd for a project of mine. Most of my > headers are now flagged as not being directly used even though they're the > root header for the symbol. replied on

[PATCH] D152686: [clangd] Enforce strict unused includes by default

2023-06-26 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb added a comment. This patch seems to have broken clangd for a project of mine. Most of my headers are now flagged as not being directly used even though they're the root header for the symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152

[PATCH] D152686: [clangd] Enforce strict unused includes by default

2023-06-12 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rGea20f339d91f: [clangd] Enforce strict unused includes by default (authored by kadircet). Changed prior to

[PATCH] D152686: [clangd] Enforce strict unused includes by default

2023-06-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:9 +#include "/usr/local/google/home/kadircet/repos/llvm/clang-tools-extra/clang-tidy/ClangTidyOptio

[PATCH] D152686: [clangd] Enforce strict unused includes by default

2023-06-12 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: ChuanqiXu, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Depen